Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: move to travis-ci.com #1728

Merged
merged 19 commits into from
Feb 12, 2019
Merged

feat: move to travis-ci.com #1728

merged 19 commits into from
Feb 12, 2019

Conversation

hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Nov 23, 2018 •
edited
Loading

@ghost ghost assigned hugomrdias Nov 23, 2018
@ghost ghost added the status/in-progress In progress label Nov 23, 2018
@hugomrdias hugomrdias changed the title feat: add ci [WIP] feat: add ci Nov 23, 2018
@hugomrdias hugomrdias changed the title [WIP] feat: add ci feat: add ci Nov 26, 2018
@hugomrdias hugomrdias force-pushed the feat/add-ci branch 3 times, most recently from 2096244 to b9eb997 Compare November 30, 2018 12:15
alanshaw
alanshaw reviewed Nov 30, 2018
View reviewed changes
.gitlab-ci.yml Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
@vasco-santos
Copy link
Member

Cooool! When can we get this merged?

@achingbrain
Copy link
Member

The GitLab build for this PR took 86 minutes. Was that expected? https://gitlab.com/ipfs-ci/js-ipfs/pipelines/38534308

@hugomrdias
Copy link
Member Author

No!! node 11 takes a long time dunno why yet probably our fault.
look at the node 10 job time 35 mins, so full pipeline 40+- mins

And remember this is running in gitlab linux shared containers , win/mac in a single mac book pro (win inside virtualbox) and no cache tweaks like travis has (ill add that later).

TLDR ignore how long it takes and look at how it works, features, interface.

Pipeline duration can only improve with dedicated machines and cache.

@jacobheun
Copy link
Contributor

I have a couple questions, but I think since the plan is to test this for a while in parallel, these aren't blockers for this PR.

  • Where can you view the code coverage report? In Jenkins it links off to codecov.io so you can view the breakdown. I'm not seeing where the artifacts are uploaded to. It would be great to log that out in the step if we can, so it's easy to find.
  • Do we have plans to add an aegir script to update the gitlab yml file if we pick gitlab? In Jenkins we have global configuration to handle updating node versions. This should probably be in an aegir check step so we don't end up with old pipelines.

Overall the individual job reporting at the pipeline level is much nicer than we have now, and individual retries is fantastic.

@hugomrdias
Copy link
Member Author

hugomrdias commented Dec 5, 2018 •
edited
Loading

pipeline-cov

the second one, yes probably

@achingbrain
Copy link
Member

It does seem like a vast improvement 😄

alanshaw
alanshaw suggested changes Dec 10, 2018
View reviewed changes
.gitlab-ci.yml Outdated Show resolved Hide resolved
alanshaw
alanshaw reviewed Dec 13, 2018
View reviewed changes
.gitlab-ci.yml Outdated
- coverage/

test-browser-firefox:
allow_failure: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this meant that the overall build will pass even if this step fails? What's the reason for adding this currently?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. dunno its a bug we break firefox in this test

.key.gen
✓ should generate a new rsa key (11404ms)

.gitlab-ci.yml Outdated
@@ -0,0 +1,89 @@
image: hugomrdias/node-alpine:test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we publish this under "ipfs" or "protocol labs" or something? What's the difference between this image and regular node-alpine?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we think about that after we test ?

FROM node:10-alpine
RUN apk add --no-cache \
    libstdc++ \
    binutils-gold \
    g++ \
    gcc \
    gnupg \
    libgcc \
    linux-headers \
    make \
    python \
    git \
    curl

.aegir.js Outdated
mocha: {
bail: true,
}
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will some of this eventually move into Aegir? Seems weird that we have so much Aegir config overrides when it is basically built to service PL JS projects.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are adding features here that aegir doesn't support yet, but it will and this will all be removed.

@alanshaw
Copy link
Member

@hugomrdias are you happy to merge this or is there more you want to add?

@hugomrdias
Copy link
Member Author

i would like to have at least chrome green, it seems the error is network related i did a restart lets see

@alanshaw
Copy link
Member

@hugomrdias could I get an update on the blockers for this now?

@alanshaw alanshaw mentioned this pull request Jan 21, 2019
Closed
@daviddias daviddias changed the title feat: add ci feat: move to travis-ci.com Feb 7, 2019
@daviddias
Copy link
Member

@hugomrdias can't wait for you to put this one on a boat 🛳 \o/ :D

@hugomrdias
feat: add ci
819eb00 
fix: update lock

fix: ignore packages

fix: fix deps and add lock

fix: fix deps 2

fix: ignore packages 2

fix: add mocha reporter to karma

fix: remove unused cmd

chore: update lock

feat: add gitattributes

feat: test attributes

feat: test attributes 2

fix: fix stderr match

fix: fix more files line endings

fix: fix line ending

chore: remove lock

chore: fix win test run

chore: ignore lock

chore: change to yarn

chore: fix cov

chore: fix cov
@hugomrdias
chore: fix feedback
a16e987
@hugomrdias
fix: remove yarn and add webworker
15dba1f
@hugomrdias
fix: add new aegir
9619e45
@hugomrdias
fix: browser tests
284c49d
@hugomrdias
feat: add travis
1f82686
@hugomrdias
fix: use new aegir with browser cov support
f6a9df0
@hugomrdias
fix: disable web security in firefox
b160ff9
@hugomrdias
fix: disable web security in firefox 2
88ffc2d
@hugomrdias
chore: trigger ci
1053000
@hugomrdias
ci: move to travis.com
c3fb2a4
@hugomrdias
fix: fix typo
c7b5998
@hugomrdias
ci: fix more line endings
63c783b
@hugomrdias
fix: fix cids
68420ff
@daviddias
Copy link
Member

image

Nice! Sad that Windows still takes so long though.

@alanshaw alanshaw merged commit e6e749d into master Feb 12, 2019
@ghost ghost removed the status/in-progress In progress label Feb 12, 2019
@alanshaw alanshaw deleted the feat/add-ci branch February 12, 2019 16:02
This was referenced Nov 18, 2020
Open
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

@alanshaw alanshaw alanshaw approved these changes

@achingbrain achingbrain Awaiting requested review from achingbrain

@jacobheun jacobheun Awaiting requested review from jacobheun

@vasco-santos vasco-santos Awaiting requested review from vasco-santos

Assignees

@hugomrdias hugomrdias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hugomrdias @vasco-santos @achingbrain @jacobheun @alanshaw @daviddias